* Re: Replacing DJB2 Hash
[not found] <CANBG-UO0xoUQq_yah=mLQWfvNQQwJng8y5UPkMSF9daYfQGe-g@mail.gmail.com>
@ 2025-03-13 20:11 ` Florian Westphal
2025-03-14 17:56 ` Phil Sutter
0 siblings, 1 reply; 2+ messages in thread
From: Florian Westphal @ 2025-03-13 20:11 UTC (permalink / raw)
To: William Stafford Parsons
Cc: pablo, p.ozlabs, regit, kadlec, fw, netfilter-devel
William Stafford Parsons <entrocraft@gmail.com> wrote:
> Hi Core Netfilter Team,
>
> I'm messaging you directly with a critical, simple patch suggestion.
>
> I registered with the username *Eightomic*, but I'm having some issues
> installing *pwclient* quickly without allowing *--break-system-packages*.
>
> Lines 176-193 could be replaced in the following file.
>
> https://git.netfilter.org/iptables/tree/iptables/nft-cache.c#n176
>
> The following code replaces it.
.... but... why?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Replacing DJB2 Hash
2025-03-13 20:11 ` Replacing DJB2 Hash Florian Westphal
@ 2025-03-14 17:56 ` Phil Sutter
0 siblings, 0 replies; 2+ messages in thread
From: Phil Sutter @ 2025-03-14 17:56 UTC (permalink / raw)
To: Florian Westphal
Cc: William Stafford Parsons, pablo, regit, kadlec, netfilter-devel
On Thu, Mar 13, 2025 at 09:11:34PM +0100, Florian Westphal wrote:
> William Stafford Parsons <entrocraft@gmail.com> wrote:
> > Hi Core Netfilter Team,
> >
> > I'm messaging you directly with a critical, simple patch suggestion.
> >
> > I registered with the username *Eightomic*, but I'm having some issues
> > installing *pwclient* quickly without allowing *--break-system-packages*.
> >
> > Lines 176-193 could be replaced in the following file.
> >
> > https://git.netfilter.org/iptables/tree/iptables/nft-cache.c#n176
> >
> > The following code replaces it.
>
> .... but... why?
Quoting from https://eightomic.com/hash-32-a/
| EIGHTOMIC HASH 32 A: THE FASTEST 32-BIT, OAAT HASHING ALGORITHM VERSUS
| CDB AND DJB2
While I doubt there's a performance improvement at all and if there is
it won't be measurable in this context, reading the footer of that page
makes me wonder whether the given algorithm is suitable for use in a GPL
licensed project to begin with.
Cheers, Phil
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-14 17:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CANBG-UO0xoUQq_yah=mLQWfvNQQwJng8y5UPkMSF9daYfQGe-g@mail.gmail.com>
2025-03-13 20:11 ` Replacing DJB2 Hash Florian Westphal
2025-03-14 17:56 ` Phil Sutter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).