From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 877F9C6FA99 for ; Fri, 10 Mar 2023 11:56:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229852AbjCJL46 (ORCPT ); Fri, 10 Mar 2023 06:56:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229967AbjCJL4d (ORCPT ); Fri, 10 Mar 2023 06:56:33 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 19764DDB24 for ; Fri, 10 Mar 2023 03:56:32 -0800 (PST) Date: Fri, 10 Mar 2023 12:56:29 +0100 From: Pablo Neira Ayuso To: Phil Sutter , Jozsef Kadlecsik , netfilter-devel@vger.kernel.org Subject: Re: [ipset PATCH 0/2] Two minor code fixes Message-ID: References: <20230222170241.26208-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Mar 02, 2023 at 10:04:14AM +0100, Phil Sutter wrote: > On Wed, Mar 01, 2023 at 11:28:36PM +0100, Pablo Neira Ayuso wrote: > > On Wed, Feb 22, 2023 at 06:02:39PM +0100, Phil Sutter wrote: > > > These were identified by Coverity tool, no problems in practice. Still > > > worth fixing to reduce noise in code checkers. > > > > LGTM. > > > > Did you run ipset xlate tests? These should not break those but just > > in case. > > I didn't, thanks for the reminder. Testsuite fails, but it does with > HEAD as well. And so does the other testsuite ("make tests"), BtW. I'll > investigate. Does this work after your testsuite updates? If so, push them out.