From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] parser_bison: simplify reset syntax
Date: Tue, 14 Mar 2023 17:13:07 +0100 [thread overview]
Message-ID: <ZBCdE7DdV2pWhSkv@orbyte.nwl.cc> (raw)
In-Reply-To: <20230314160537.827655-1-pablo@netfilter.org>
On Tue, Mar 14, 2023 at 05:05:37PM +0100, Pablo Neira Ayuso wrote:
> Simplify:
>
> *reset rules* *chain* ['family'] 'table' ['chain]'
> to
> *reset rules* ['family'] 'table' 'chain'
>
> *reset rules* *table* ['family'] 'table'
> to
> *reset rules* ['family'] 'table'
>
> *reset counters* ['family'] *table* 'table'
> to
> *reset counters* ['family'] 'table'
>
> *reset quotas* ['family'] *table* 'table'
> to
> *reset quotas* ['family'] 'table'
>
> Previous syntax remains in place for backward compatibility.
>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
> doc/nft.txt | 8 ++++----
> src/parser_bison.y | 20 ++++++++++++++++++++
> 2 files changed, 24 insertions(+), 4 deletions(-)
>
> diff --git a/doc/nft.txt b/doc/nft.txt
> index 0d60c7520d31..8624d5dd8f60 100644
> --- a/doc/nft.txt
> +++ b/doc/nft.txt
> @@ -491,8 +491,8 @@ RULES
> {*delete* | *reset*} *rule* ['family'] 'table' 'chain' *handle* 'handle'
> *destroy rule* ['family'] 'table' 'chain' *handle* 'handle'
> *reset rules* ['family']
> -*reset rules* *table* ['family'] 'table'
> -*reset rules* *chain* ['family'] 'table' ['chain']
> +*reset rules* ['family'] 'table'
> +*reset chain* ['family'] 'table' 'chain'
~~~~~
This is a leftover. You may combine all three lines into a single:
| *reset rules* ['family'] ['table' ['chain']]
Cheers, Phil
prev parent reply other threads:[~2023-03-14 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 16:05 [PATCH nft] parser_bison: simplify reset syntax Pablo Neira Ayuso
2023-03-14 16:13 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBCdE7DdV2pWhSkv@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox