Re: [PATCH nft,v2] parser_bison: simplify reset syntax

[Phil Sutter <phil@nwl.cc>]

On Tue, Mar 14, 2023 at 05:51:38PM +0100, Pablo Neira Ayuso wrote:
> Simplify:
> 
> *reset rules* *chain* ['family'] 'table' ['chain]'
> to
> *reset rules* ['family'] 'table' 'chain'
> 
> *reset rules* *table* ['family'] 'table'
> to
> *reset rules* ['family'] 'table'
> 
> *reset counters* ['family'] *table* 'table'
> to
> *reset counters* ['family'] 'table'
> 
> *reset quotas* ['family'] *table* 'table'
> to
> *reset quotas* ['family'] 'table'
> 
> Previous syntax remains in place for backward compatibility.
> 
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
> v2: combine all three lines in manpage
>     remove leftover
> 
>  doc/nft.txt        |  8 +++-----
>  src/parser_bison.y | 20 ++++++++++++++++++++
>  2 files changed, 23 insertions(+), 5 deletions(-)
> 
> diff --git a/doc/nft.txt b/doc/nft.txt
> index 0d60c7520d31..82d3bc4211f1 100644
> --- a/doc/nft.txt
> +++ b/doc/nft.txt
> @@ -490,9 +490,7 @@ RULES
>  *replace rule* ['family'] 'table' 'chain' *handle* 'handle' 'statement' ... [*comment* 'comment']
>  {*delete* | *reset*} *rule* ['family'] 'table' 'chain' *handle* 'handle'
>  *destroy rule* ['family'] 'table' 'chain' *handle* 'handle'
> -*reset rules* ['family']
> -*reset rules* *table* ['family'] 'table'
> -*reset rules* *chain* ['family'] 'table' ['chain']
> +*reset rules* ['family'] ['table'] ['chain']

Sorry for being pedantic, but the above indicates something like 'reset
rules ip mychain' is allowed although it isn't.