From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH iptables 2/2] ebtables-nft: add broute table emulation
Date: Tue, 4 Apr 2023 21:44:55 +0200 [thread overview]
Message-ID: <ZCx+N9XeZgyx3KZu@orbyte.nwl.cc> (raw)
In-Reply-To: <20230404094544.2892-2-fw@strlen.de>
On Tue, Apr 04, 2023 at 11:45:44AM +0200, Florian Westphal wrote:
[...]
> --- a/iptables/ebtables-nft.8
> +++ b/iptables/ebtables-nft.8
[...]
> @@ -93,17 +96,13 @@ For the extension targets please refer to the
> .B "TARGET EXTENSIONS"
> section of this man page.
> .SS TABLES
> -As stated earlier, there are two ebtables tables in the Linux
> -kernel. The table names are
> -.BR filter " and " nat .
> -Of these two tables,
> +As stated earlier, the table names are
> +.BR filter ", " nat " and " broute .
> +Of these tables,
> the filter table is the default table that the command operates on.
> -If you are working with the filter table, then you can drop the '-t filter'
> -argument to the ebtables command. However, you will need to provide
> -the -t argument for
> -.B nat
> -table. Moreover, the -t argument must be the
> -first argument on the ebtables command line, if used.
> +If you are working with the a table other than filter, you will need to provide
Typo here ("the a" -> "a").
Also this patch broke
iptables/tests/shell/testcases/ebtables/0001-ebtables-basic_0
("broute" table name did not fail anymore, so nothing serious).
Folded both fixes into this commit, then applied the series.
Thanks for working on it!
prev parent reply other threads:[~2023-04-04 19:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 9:45 [PATCH iptables 1/2] include: update nf_tables uapi header Florian Westphal
2023-04-04 9:45 ` [PATCH iptables 2/2] ebtables-nft: add broute table emulation Florian Westphal
2023-04-04 18:16 ` Sriram Yagnaraman
2023-04-04 18:50 ` Florian Westphal
2023-04-04 19:44 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCx+N9XeZgyx3KZu@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox