From: Phil Sutter <phil@nwl.cc>
To: netfilter-devel@vger.kernel.org
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, Florian Westphal <fw@strlen.de>
Subject: Re: [iptables PATCH 0/3] Extract nftnl_rule parsing code
Date: Wed, 3 May 2023 19:36:50 +0200 [thread overview]
Message-ID: <ZFKbskUv6RlJZLjj@orbyte.nwl.cc> (raw)
In-Reply-To: <20230421174014.17014-1-phil@nwl.cc>
On Fri, Apr 21, 2023 at 07:40:11PM +0200, Phil Sutter wrote:
> nft-shared.c was already oversized, upcoming enhancement of the
> nftnl_rule parser will add to that. So prepare any further work in that
> field by creating a common 'nft-ruleparse.c' source and one for each
> family to hold all the parsing code (basically the stack below
> nft_rule_to_iptables_command_state).
>
> Collect the existing expression parsing callbacks in a new struct
> nft_ruleparse_ops and add a pointer to it into nft_family_ops. This way
> the callbacks may be static and the nft-ruleparse-<family>.c sources
> only export their ops object.
>
> This series does things somewhat gradually:
>
> * First pull everything from nft-shared.c into nft-ruleparse.c (likewise
> with header files)
> * Then perform the *_ops struct changes which should not have a
> functional implication
> * Finally weed parsers from nft-<family>.c files into
> nft-ruleparse-<family>.c ones.
Series applied after rebasing it onto current HEAD - the previous
arptables-related fixes caused a minor conflict.
prev parent reply other threads:[~2023-05-03 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 17:40 [iptables PATCH 0/3] Extract nftnl_rule parsing code Phil Sutter
2023-04-21 17:40 ` [iptables PATCH 1/3] nft: Introduce nft-ruleparse.{c,h} Phil Sutter
2023-04-21 17:40 ` [iptables PATCH 2/3] nft: Extract rule parsing callbacks from nft_family_ops Phil Sutter
2023-04-21 17:40 ` [iptables PATCH 3/3] nft: ruleparse: Create family-specific source files Phil Sutter
2023-05-03 17:36 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFKbskUv6RlJZLjj@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox