From: Phil Sutter <phil@nwl.cc>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>,
Christian Marangi <ansuelsmth@gmail.com>
Subject: Re: [iptables PATCH] xshared: fix memory leak in should_load_proto
Date: Fri, 16 Jun 2023 18:22:36 +0200 [thread overview]
Message-ID: <ZIyMTLdEV3XCIoDZ@orbyte.nwl.cc> (raw)
In-Reply-To: <rpro25oo-2036-33rr-4258-o15rn7665o73@vanv.qr>
Hi Jan,
On Tue, May 30, 2023 at 06:11:09PM +0200, Jan Engelhardt wrote:
[...]
> After 13 years, the code I once wrote feels weird. In essence, find_proto is
> called twice, but that should not be necessary because cs->proto_used already
> tracks whether this was done.
> [e.g. use `iptables -A INPUT -p tcp --dport 25 --unrecognized` to trigger]
>
> Could someone cross check my alternative proposal I have below?
Thanks for the fix! Patch applied with minor subject and whitespace
fixes.
prev parent reply other threads:[~2023-06-16 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 17:18 [iptables PATCH] xshared: fix memory leak in should_load_proto Christian Marangi
2023-05-30 13:04 ` Phil Sutter
2023-05-30 16:11 ` Jan Engelhardt
2023-06-16 16:22 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIyMTLdEV3XCIoDZ@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=ansuelsmth@gmail.com \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).