From: Phil Sutter <phil@nwl.cc>
To: Jacek Tomasiak <jacek.tomasiak@gmail.com>
Cc: netfilter-devel@vger.kernel.org, Jacek Tomasiak <jtomasiak@arista.com>
Subject: Re: [iptables PATCH] iptables: Fix setting of ipv6 counters
Date: Wed, 21 Jun 2023 13:52:11 +0200 [thread overview]
Message-ID: <ZJLka2LF9pN/jdiK@orbyte.nwl.cc> (raw)
In-Reply-To: <20230619104454.1216-1-jacek.tomasiak@gmail.com>
On Mon, Jun 19, 2023 at 12:44:54PM +0200, Jacek Tomasiak wrote:
> When setting counters using ip6tables-nft -c X Y the X and Y values were
> not stored.
>
> This is a fix based on 9baf3bf0e77dab6ca4b167554ec0e57b65d0af01 but
> applied to the nft variant of ipv6 not the legacy.
>
> Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1647
> Signed-off-by: Jacek Tomasiak <jtomasiak@arista.com>
> Signed-off-by: Jacek Tomasiak <jacek.tomasiak@gmail.com>
Thanks for the patch! It looks like this is a bug in ip6tables-nft since
day 1, at least I see how commit 0391677c1a0b2 ("xtables: add IPv6
support") already has it wrong.
Applied after adding Fixes: tag and folding a change to one of the shell
test cases to cover it.
Thanks, Phil
prev parent reply other threads:[~2023-06-21 11:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 10:44 [iptables PATCH] iptables: Fix setting of ipv6 counters Jacek Tomasiak
2023-06-21 11:52 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJLka2LF9pN/jdiK@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=jacek.tomasiak@gmail.com \
--cc=jtomasiak@arista.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).