netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Jacek Tomasiak <jacek.tomasiak@gmail.com>
Cc: netfilter-devel@vger.kernel.org, Jacek Tomasiak <jtomasiak@arista.com>
Subject: Re: [iptables PATCH] iptables: Fix handling of non-existent chains
Date: Wed, 21 Jun 2023 13:53:06 +0200	[thread overview]
Message-ID: <ZJLkolFNPVChnQLF@orbyte.nwl.cc> (raw)
In-Reply-To: <20230619114636.7672-1-jacek.tomasiak@gmail.com>

On Mon, Jun 19, 2023 at 01:46:36PM +0200, Jacek Tomasiak wrote:
> Since 694612adf87 the "compatibility" check considers non-existent
> chains as "incompatible". This broke some scripts which used calls
> like `iptables -L CHAIN404` to test for chain existence and expect
> "No chain/target/match by that name." in the output.
> 
> This patch changes the logic of `nft_is_table_compatible()` to
> report non-existent chains as "compatible" which restores the old
> behavior.
> 
> Fixes: 694612adf87 ("nft: Fix selective chain compatibility checks")
> Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1648
> Signed-off-by: Jacek Tomasiak <jtomasiak@arista.com>
> Signed-off-by: Jacek Tomasiak <jacek.tomasiak@gmail.com>

Also applied after adding testsuite coverage to it.

Thanks, Phil

      reply	other threads:[~2023-06-21 11:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-19 11:46 [iptables PATCH] iptables: Fix handling of non-existent chains Jacek Tomasiak
2023-06-21 11:53 ` Phil Sutter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJLkolFNPVChnQLF@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=jacek.tomasiak@gmail.com \
    --cc=jtomasiak@arista.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).