From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netfilter-devel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E5C50EB64DD
	for <netfilter-devel@archiver.kernel.org>; Thu, 13 Jul 2023 11:36:28 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233126AbjGMLg1 (ORCPT
        <rfc822;netfilter-devel@archiver.kernel.org>);
        Thu, 13 Jul 2023 07:36:27 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40916 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230138AbjGMLg1 (ORCPT
        <rfc822;netfilter-devel@vger.kernel.org>);
        Thu, 13 Jul 2023 07:36:27 -0400
Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207])
        by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0407E2D67
        for <netfilter-devel@vger.kernel.org>; Thu, 13 Jul 2023 04:35:50 -0700 (PDT)
Date:   Thu, 13 Jul 2023 13:34:45 +0200
From:   Pablo Neira Ayuso <pablo@netfilter.org>
To:     Phil Sutter <phil@nwl.cc>, netfilter-devel@vger.kernel.org,
        fw@strlen.de, igor@gooddata.com
Subject: Re: [PATCH iptables] nft-bridge: pass context structure to
 ops->add() to improve anonymous set support
Message-ID: <ZK/hVdvEcJobNz7W@calendula>
References: <20230712095912.140792-1-pablo@netfilter.org>
 <ZK7fTtDVp61+7byX@calendula>
 <ZK/a+LkEDbcAcZDZ@orbyte.nwl.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ZK/a+LkEDbcAcZDZ@orbyte.nwl.cc>
Precedence: bulk
List-ID: <netfilter-devel.vger.kernel.org>
X-Mailing-List: netfilter-devel@vger.kernel.org

On Thu, Jul 13, 2023 at 01:07:36PM +0200, Phil Sutter wrote:
> On Wed, Jul 12, 2023 at 07:13:50PM +0200, Pablo Neira Ayuso wrote:
> > On Wed, Jul 12, 2023 at 11:59:12AM +0200, Pablo Neira Ayuso wrote:
> > > diff --git a/iptables/nft.c b/iptables/nft.c
> > > index 1cb104e75ccc..59e3fa7079c4 100644
> > > --- a/iptables/nft.c
> > > +++ b/iptables/nft.c
> > [...]
> > > @@ -2878,6 +2888,9 @@ int nft_rule_zero_counters(struct nft_handle *h, const char *chain,
> > >  {
> > >  	struct iptables_command_state cs = {};
> > >  	struct nftnl_rule *r, *new_rule;
> > > +	struct nft_rule_ctx ctx = {
> > > +		.command = NFT_COMPAT_RULE_ZERO,
> > 
> > BTW. I changed this to:
> > 
> >                 .command = NFT_COMPAT_RULE_APPEND,
> > 
> > before pushing it out, for the record.
> 
> Hmm. :)
> 
> I'm curious how to trigger the problem. Could you please provide a
> test-case?

I suspect a problem might occur if the rule that is zeroed generates a
native expression.

nft_rule_zero_counters() calls _append() in practise, to readd the
rule after deleting it to zero the counters.