From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, fw@strlen.de, igor@gooddata.com
Subject: Re: [PATCH iptables] nft-bridge: pass context structure to ops->add() to improve anonymous set support
Date: Thu, 13 Jul 2023 13:50:39 +0200 [thread overview]
Message-ID: <ZK/lD2Hpfrtb0qWB@orbyte.nwl.cc> (raw)
In-Reply-To: <20230712095912.140792-1-pablo@netfilter.org>
On Wed, Jul 12, 2023 at 11:59:12AM +0200, Pablo Neira Ayuso wrote:
[...]
> diff --git a/iptables/nft.c b/iptables/nft.c
> index 1cb104e75ccc..59e3fa7079c4 100644
> --- a/iptables/nft.c
> +++ b/iptables/nft.c
> @@ -1154,7 +1154,8 @@ gen_lookup(uint32_t sreg, const char *set_name, uint32_t set_id, uint32_t flags)
> #define NFT_DATATYPE_ETHERADDR 9
>
> static int __add_nft_among(struct nft_handle *h, const char *table,
> - struct nftnl_rule *r, struct nft_among_pair *pairs,
> + struct nft_rule_ctx *ctx, struct nftnl_rule *r,
> + struct nft_among_pair *pairs,
> int cnt, bool dst, bool inv, bool ip)
> {
> uint32_t set_id, type = NFT_DATATYPE_ETHERADDR, len = ETH_ALEN;
Is there something missing here? Neither add_nft_among() nor
__add_nft_among() use the new parameter. Or is this left over from a
previous version of the fix?
Cheers, Phil
prev parent reply other threads:[~2023-07-13 11:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 9:59 [PATCH iptables] nft-bridge: pass context structure to ops->add() to improve anonymous set support Pablo Neira Ayuso
2023-07-12 11:05 ` Igor Raits
2023-07-12 14:01 ` Pablo Neira Ayuso
2023-07-12 17:13 ` Pablo Neira Ayuso
2023-07-13 11:07 ` Phil Sutter
2023-07-13 11:34 ` Pablo Neira Ayuso
2023-07-13 11:50 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK/lD2Hpfrtb0qWB@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=igor@gooddata.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).