From: Simon Horman <simon.horman@corigine.com>
To: Lin Ma <linma@zju.edu.cn>
Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] netfilter: conntrack: validate cta_ip via parsing
Date: Thu, 13 Jul 2023 16:03:04 +0100 [thread overview]
Message-ID: <ZLASKOr2ZqZtkpCb@corigine.com> (raw)
In-Reply-To: <20230712133236.280999-1-linma@zju.edu.cn>
On Wed, Jul 12, 2023 at 09:32:36PM +0800, Lin Ma wrote:
> In current ctnetlink_parse_tuple_ip() function, nested parsing and
> validation is splitting as two parts, which could be cleanup to a
> simplified form. As the nla_parse_nested_deprecated function
> supports validation in the fly. These two finially reach same place
> __nla_validate_parse with same validate flag.
>
> nla_parse_nested_deprecated
> __nla_parse(.., NL_VALIDATE_LIBERAL, ..)
> __nla_validate_parse
>
> nla_validate_nested_deprecated
> __nla_validate_nested(.., NL_VALIDATE_LIBERAL, ..)
> __nla_validate
> __nla_validate_parse
>
> This commit removes the call to nla_validate_nested_deprecated and pass
> cta_ip_nla_policy when do parsing.
>
> Signed-off-by: Lin Ma <linma@zju.edu.cn>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
prev parent reply other threads:[~2023-07-13 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 13:32 [PATCH v2] netfilter: conntrack: validate cta_ip via parsing Lin Ma
2023-07-13 15:03 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLASKOr2ZqZtkpCb@corigine.com \
--to=simon.horman@corigine.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linma@zju.edu.cn \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).