From: Phil Sutter <phil@nwl.cc>
To: Thomas Haller <thaller@redhat.com>
Cc: NetFilter <netfilter-devel@vger.kernel.org>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [nft v2 PATCH 1/3] nftables: add input flags for nft_ctx
Date: Fri, 14 Jul 2023 12:16:08 +0200 [thread overview]
Message-ID: <ZLEgaNIH/ZD4hnf3@orbyte.nwl.cc> (raw)
In-Reply-To: <20230714084943.1080757-1-thaller@redhat.com>
On Fri, Jul 14, 2023 at 10:48:51AM +0200, Thomas Haller wrote:
[...]
> +=== nft_ctx_input_get_flags() and nft_ctx_input_set_flags()
> +The flags setting controls the input format.
Note how we turn on JSON input parsing if JSON output is enabled.
I think we could tidy things up by introducing NFT_CTX_INPUT_JSON and
flip it from nft_ctx_output_set_flags() to match NFT_CTX_OUTPUT_JSON for
compatibility?
Cheers, Phil
next prev parent reply other threads:[~2023-07-14 10:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 17:46 [nft PATCH] nftables: add flag for nft context to avoid blocking getaddrinfo() Thomas Haller
2023-07-10 17:58 ` Pablo Neira Ayuso
2023-07-14 8:48 ` [nft v2 PATCH 1/3] nftables: add input flags for nft_ctx Thomas Haller
2023-07-14 8:48 ` [nft v2 PATCH 2/3] nftables: add input flag NFT_CTX_INPUT_NO_DNS to avoid blocking getaddrinfo() Thomas Haller
2023-07-14 10:07 ` Phil Sutter
2023-07-18 9:12 ` Thomas Haller
2023-07-14 8:48 ` [nft v2 PATCH 3/3] py: add input_{set,get}_flags() API to helpers Thomas Haller
2023-07-14 9:59 ` Phil Sutter
2023-07-18 10:07 ` Thomas Haller
2023-07-14 10:16 ` Phil Sutter [this message]
2023-07-18 9:05 ` [nft v2 PATCH 1/3] nftables: add input flags for nft_ctx Thomas Haller
2023-07-18 9:33 ` Phil Sutter
2023-07-18 10:31 ` Thomas Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLEgaNIH/ZD4hnf3@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).