netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Leah Neukirchen <leah@vuxu.org>
Cc: arturo@netfilter.org, netfilter-devel@vger.kernel.org,
	Jan Engelhardt <jengelh@inai.de>,
	phil@nwl.cc
Subject: Re: [ANNOUNCE] nftables 1.0.8 release
Date: Fri, 21 Jul 2023 15:44:54 +0200	[thread overview]
Message-ID: <ZLqL1g6YAbNOloRN@calendula> (raw)
In-Reply-To: <87351i8unw.fsf@vuxu.org>

Hi,

Thanks for your patch.

On Thu, Jul 20, 2023 at 05:33:23PM +0200, Leah Neukirchen wrote:
> For Void Linux, I have applied this fix, which results in installing
> the same way was for 1.0.7 (else it creates a .egg directory which isn't
> loaded properly on a plain Python):
> 
> --- a/py/Makefile.am
> +++ b/py/Makefile.am
> @@ -7,7 +7,7 @@
>  install-exec-local:
>  	cd $(srcdir) && \
>  		$(PYTHON_BIN) setup.py build --build-base $(abs_builddir) \
> -		install --prefix $(DESTDIR)$(prefix)
> +		install --prefix $(prefix) --root $(DESTDIR)
>  
>  uninstall-local:
>  	rm -rf $(DESTDIR)$(prefix)/lib*/python*/site-packages/nftables

I proposed the following patch to remove py integration with
autotools/automake:

https://patchwork.ozlabs.org/project/netfilter-devel/patch/20230718120119.172757-2-pablo@netfilter.org/

Rationale is that this provides more flexibility to users and
packagers to deal with nftables Python support.

Python install infrastructure is a moving target, setup.py is still
left in place so you can still invoke it.

Does this make sense to you?

  reply	other threads:[~2023-07-21 13:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14 11:05 [ANNOUNCE] nftables 1.0.8 release Pablo Neira Ayuso
2023-07-17 10:25 ` Arturo Borrero Gonzalez
2023-07-17 10:28   ` Pablo Neira Ayuso
2023-07-20 15:33   ` Leah Neukirchen
2023-07-21 13:44     ` Pablo Neira Ayuso [this message]
2023-07-21 14:03       ` Leah Neukirchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLqL1g6YAbNOloRN@calendula \
    --to=pablo@netfilter.org \
    --cc=arturo@netfilter.org \
    --cc=jengelh@inai.de \
    --cc=leah@vuxu.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).