From: Phil Sutter <phil@nwl.cc>
To: "Fernando F. Mancera" <ffmancera@riseup.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] tests: shell: Review test-cases for destroy command
Date: Thu, 3 Aug 2023 12:09:35 +0200 [thread overview]
Message-ID: <ZMt83w+uPz55z6kf@orbyte.nwl.cc> (raw)
In-Reply-To: <8e5ab358-23dd-56dd-bc7a-b551ef950689@riseup.net>
On Thu, Aug 03, 2023 at 12:45:14AM +0200, Fernando F. Mancera wrote:
> Thanks Phil, LGTM. Just one comment:
>
> On 01/08/2023 13:42, Phil Sutter wrote:
> > Having separate files for successful destroy of existing and
> > non-existing objects is a bit too much, just combine them into one.
> >
> > While being at it:
> >
> > * Check that deleted objects are actually gone
>
> I think that is done automatically with the expected ruleset.. isn't? If
> not, what is the purpose of having them?
Oh, I missed those entirely! I'll prepare a v2 dropping the manual
checks and deleting the leftovers.
Thanks, Phil
prev parent reply other threads:[~2023-08-03 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 11:42 [nft PATCH] tests: shell: Review test-cases for destroy command Phil Sutter
2023-08-02 22:45 ` Fernando F. Mancera
2023-08-03 10:09 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMt83w+uPz55z6kf@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=ffmancera@riseup.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).