From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 009C3C001E0 for ; Thu, 10 Aug 2023 12:15:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232467AbjHJMPy (ORCPT ); Thu, 10 Aug 2023 08:15:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbjHJMPx (ORCPT ); Thu, 10 Aug 2023 08:15:53 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4003F196 for ; Thu, 10 Aug 2023 05:15:53 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1qU4Zz-00055C-Dl; Thu, 10 Aug 2023 14:15:51 +0200 Date: Thu, 10 Aug 2023 14:15:51 +0200 From: Phil Sutter To: netfilter-devel@vger.kernel.org Cc: Gaurav Gupta Subject: Re: [iptables PATCH] Use SOCK_CLOEXEC/O_CLOEXEC where available Message-ID: Mail-Followup-To: Phil Sutter , netfilter-devel@vger.kernel.org, Gaurav Gupta References: <20230810112542.21382-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230810112542.21382-1-phil@nwl.cc> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Aug 10, 2023 at 01:25:42PM +0200, Phil Sutter wrote: > No need for the explicit fcntl() call, request the behaviour when > opening the descriptor. > > One fcntl() call setting FD_CLOEXEC remains in extensions/libxt_bpf.c, > the indirect syscall seems not to support passing the flag directly. > > Reported-by: Gaurav Gupta > Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1104 > Signed-off-by: Phil Sutter Patch applied.