From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBC97EE4993 for ; Tue, 22 Aug 2023 08:54:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233946AbjHVIy4 (ORCPT ); Tue, 22 Aug 2023 04:54:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233949AbjHVIy4 (ORCPT ); Tue, 22 Aug 2023 04:54:56 -0400 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9E7AE4F for ; Tue, 22 Aug 2023 01:54:30 -0700 (PDT) Received: from [78.30.34.192] (port=41976 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qYN9e-00HGOC-FG; Tue, 22 Aug 2023 10:54:29 +0200 Date: Tue, 22 Aug 2023 10:54:25 +0200 From: Pablo Neira Ayuso To: Thomas Haller Cc: NetFilter Subject: Re: [nft PATCH 1/2] meta: don't assume time_t is 64 bit in date_type_print() Message-ID: References: <20230822081318.1370371-1-thaller@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230822081318.1370371-1-thaller@redhat.com> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Aug 22, 2023 at 10:13:09AM +0200, Thomas Haller wrote: > time_t on 32bit arch is not uint64_t. Even if it always were, it would > be ugly to make such an assumption (without a static assert). Copy the > value to a time_t variable first. Applied, thanks.