From: Phil Sutter <phil@nwl.cc>
To: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] tests: shell: Fix for ineffective 0007-mid-restore-flush_0
Date: Thu, 14 Sep 2023 12:35:11 +0200 [thread overview]
Message-ID: <ZQLh3+6eWML8waDc@orbyte.nwl.cc> (raw)
In-Reply-To: <20230914073116.29450-1-phil@nwl.cc>
On Thu, Sep 14, 2023 at 09:31:16AM +0200, Phil Sutter wrote:
> The test did not catch non-zero exit status of the spawned coprocess. To
> make it happen, Drop the line killing it (it will exit anyway) and pass
> its PID to 'wait'.
>
> While being at it, put the sleep into the correct spot (otherwise the
> check for chain 'foo' existence fails as it runs too early) and make
> said chain existence check effective.
>
> Fixes: 4e3c11a6f5a94 ("nft: Fix for ruleset flush while restoring")
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Patch applied.
prev parent reply other threads:[~2023-09-14 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 7:31 [iptables PATCH] tests: shell: Fix for ineffective 0007-mid-restore-flush_0 Phil Sutter
2023-09-14 10:35 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQLh3+6eWML8waDc@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).