From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Thomas Haller <thaller@redhat.com>
Cc: NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft 1/1] netlink: fix leaking typeof_expr_data/typeof_expr_key in netlink_delinearize_set()
Date: Tue, 19 Sep 2023 15:43:14 +0200 [thread overview]
Message-ID: <ZQmlctgHDx6U3T21@calendula> (raw)
In-Reply-To: <20230914140952.4177765-1-thaller@redhat.com>
On Thu, Sep 14, 2023 at 04:09:50PM +0200, Thomas Haller wrote:
> There are various code paths that return without freeing typeof_expr_data
> and typeof_expr_key. It's not at all obvious, that there isn't a leak
> that way. Quite possibly there is a leak. Fix it, or at least make the
> code more obviously correct.
Applied, thanks
prev parent reply other threads:[~2023-09-19 13:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 14:09 [PATCH nft 1/1] netlink: fix leaking typeof_expr_data/typeof_expr_key in netlink_delinearize_set() Thomas Haller
2023-09-19 13:43 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQmlctgHDx6U3T21@calendula \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox