From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>, g@calendula
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nf_tables: fix memory leak when more than 255 elements expired
Date: Tue, 19 Sep 2023 16:12:55 +0200 [thread overview]
Message-ID: <ZQmsZ/LPy+HMYZIo@calendula> (raw)
In-Reply-To: <ZQmsUBdJn2JH5tOt@calendula>
On Tue, Sep 19, 2023 at 04:12:34PM +0200, Pablo Neira Ayuso wrote:
> On Tue, Sep 19, 2023 at 03:59:38PM +0200, Florian Westphal wrote:
> > Florian Westphal <fw@strlen.de> wrote:
> > > When more than 255 elements expire we're supposed to switch to a new gc
> > > container structure, but nft_trans_gc_space() always returns false in this
> >
> > Grrr. This should read 'always returns true' or 'never returns false',
> > but not *THIS*. I'll fix this up when applying this, probably tomorrow
> > morning.
>
> You could amend the fix when applying this.
I mean, this patch description, as you prefer.
prev parent reply other threads:[~2023-09-19 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 13:36 [PATCH nf] netfilter: nf_tables: fix memory leak when more than 255 elements expired Florian Westphal
2023-09-19 13:59 ` Florian Westphal
2023-09-19 14:12 ` Pablo Neira Ayuso
2023-09-19 14:12 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQmsZ/LPy+HMYZIo@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=g@calendula \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).