From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Thomas Haller <thaller@redhat.com>
Cc: NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft] datatype: return const pointer from datatype_get()
Date: Thu, 21 Sep 2023 00:00:18 +0200 [thread overview]
Message-ID: <ZQtrcts0lPxZioka@calendula> (raw)
In-Reply-To: <20230920200922.867334-1-thaller@redhat.com>
On Wed, Sep 20, 2023 at 10:09:19PM +0200, Thomas Haller wrote:
> "struct datatype" is for the most part immutable, and most callers deal
> with const pointers. That's why datatype_get() accepts a const pointer
> to increase the reference count (mutating the refcnt field).
>
> It should also return a const pointer. In fact, all callers are fine
> with that already.
Applied, thanks Thomas
prev parent reply other threads:[~2023-09-20 22:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 20:09 [PATCH nft] datatype: return const pointer from datatype_get() Thomas Haller
2023-09-20 22:00 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQtrcts0lPxZioka@calendula \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox