From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [nf PATCH 2/5] netfilter: nf_tables: Add locking for NFT_MSG_GETRULE_RESET requests
Date: Tue, 26 Sep 2023 11:34:43 +0200 [thread overview]
Message-ID: <ZRKlszo1ra1EakD+@orbyte.nwl.cc> (raw)
In-Reply-To: <20230925195317.GC22532@breakpoint.cc>
On Mon, Sep 25, 2023 at 09:53:17PM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Sat, Sep 23, 2023 at 06:18:13PM +0200, Florian Westphal wrote:
> > > callback_that_might_reset()
> > > {
> > > try_module_get ...
> > > rcu_read_unlock()
> > > mutex_lock(net->commit_mutex)
> > > dumper();
> > > mutex_unlock(net->commit_mutex)
> > > rcu_read_lock();
> > > module_put()
> > > }
> > >
> > > should do the trick.
> >
> > Idiom above LGTM, *except for net->commit_mutex*. Please do not use
> > ->commit_mutex: This will stall ruleset updates for no reason, netlink
> > dump would grab and release such mutex for each netlink_recvmsg() call
> > and netlink dump side will always retry because of NLM_F_EINTR.
>
> It will stall updates, but for good reason: we are making changes to the
> expressions state.
This also disqualifies the use of Pablo's suggested reset_lock, right?
Cheers, Phil
next prev parent reply other threads:[~2023-09-26 9:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 1:38 [nf PATCH 0/5] Introduce locking for reset requests Phil Sutter
2023-09-23 1:38 ` [nf PATCH 1/5] netfilter: nf_tables: Don't allocate nft_rule_dump_ctx Phil Sutter
2023-09-23 1:38 ` [nf PATCH 2/5] netfilter: nf_tables: Add locking for NFT_MSG_GETRULE_RESET requests Phil Sutter
2023-09-23 11:04 ` Florian Westphal
2023-09-23 15:03 ` Phil Sutter
2023-09-23 16:18 ` Florian Westphal
2023-09-25 9:32 ` Pablo Neira Ayuso
2023-09-25 19:53 ` Florian Westphal
2023-09-26 9:34 ` Phil Sutter [this message]
2023-09-26 10:09 ` Pablo Neira Ayuso
2023-09-26 12:14 ` Phil Sutter
2023-09-26 13:34 ` Pablo Neira Ayuso
2023-09-26 13:59 ` Phil Sutter
2023-09-27 11:41 ` Florian Westphal
2023-09-27 12:54 ` Phil Sutter
2023-09-25 11:02 ` Pablo Neira Ayuso
2023-09-25 10:47 ` Pablo Neira Ayuso
2023-09-26 9:14 ` Phil Sutter
2023-09-26 10:00 ` Pablo Neira Ayuso
2023-09-25 10:48 ` Pablo Neira Ayuso
2023-09-25 11:01 ` Pablo Neira Ayuso
2023-09-23 1:38 ` [nf PATCH 3/5] netfilter: nf_tables: Introduce struct nft_obj_dump_ctx Phil Sutter
2023-09-23 1:38 ` [nf PATCH 4/5] netfilter: nf_tables: Add locking for NFT_MSG_GETOBJ_RESET requests Phil Sutter
2023-09-23 1:38 ` [nf PATCH 5/5] netfilter: nf_tables: Add locking for NFT_MSG_GETSETELEM_RESET requests Phil Sutter
2023-09-25 10:53 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRKlszo1ra1EakD+@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).