From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 718F2EE0205 for ; Tue, 26 Sep 2023 19:58:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235753AbjIZT6U (ORCPT ); Tue, 26 Sep 2023 15:58:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235799AbjIZT6T (ORCPT ); Tue, 26 Sep 2023 15:58:19 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C87F1192 for ; Tue, 26 Sep 2023 12:58:10 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1qlEC8-00074E-Sm; Tue, 26 Sep 2023 21:58:08 +0200 Date: Tue, 26 Sep 2023 21:58:08 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [nft PATCH] tests: shell: features: Fix table owner flag check Message-ID: Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , Florian Westphal , netfilter-devel@vger.kernel.org References: <20230926195622.31984-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230926195622.31984-1-phil@nwl.cc> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Sep 26, 2023 at 09:56:22PM +0200, Phil Sutter wrote: > The keyword is "flags", not "flag". Resulted in a false-negative: > > features/table_flag_owner.nft:4:2-5: Error: syntax error, unexpected string > flag owner; > ^^^^ > > Fixes: 10373f0936cd3 ("tests: shell: skip flowtable-uaf if we lack table owner support") > Signed-off-by: Phil Sutter Patch applied.