Re: [PATCH nft 3/3,v2] netlink_linearize: skip set element expression in map statement key

[Phil Sutter <phil@nwl.cc>]

On Wed, Sep 27, 2023 at 01:19:31PM +0200, Pablo Neira Ayuso wrote:
> Hi Phil,
> 
> On Wed, Sep 27, 2023 at 01:10:09PM +0200, Phil Sutter wrote:
> > Hi Pablo,
> > 
> > On Wed, Sep 27, 2023 at 10:42:36AM +0200, Pablo Neira Ayuso wrote:
> > [...]
> > > Did you ever follow up on your pull request for libjansson or did you
> > > find a way to dynamically allocate the error reporting area that they
> > > complain about?
> > 
> > All done. When there were no technical reasons left to reject it, I was
> > told it's not important enough[1].
> 
> Concern seems to be related to extra memory consumption.
> 
> Would it be possible to revisit your patchset so the extra memory
> consumption for error reporting only happens if some flag is toggle to
> request this? Some sort of opt-in mechanism. Would that be feasible?

You mean eliminate the 'location' pointer field from json_*_t structs?
Because apart from that, the whole thing is already opt-in based on
JSON_STORE_LOCATION flag.

> > > Error reporting with libjansson is very rudimentary, there is no way
> > > to tell what precisely in the command that is represented in JSON is
> > > actually causing the error, this coarse grain error reporting is too
> > > broad.
> > 
> > Indeed, and my implementation would integrate nicely with nftables'
> > erecs.
> 
> Yes, I like that.
> 
> > I actually considered forking the project. Or we just ship a copy of the
> > lib with nftables sources?
> 
> I would try to get back to them to refresh and retry.

Oh well. I'll try an approach which eliminates the pointer if not
enabled. The terse feedback and pessimistic replies right from the start
convinced me though they just don't want it.

Cheers, Phil