From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B48F7E7F14E for ; Wed, 27 Sep 2023 13:21:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231781AbjI0NVU (ORCPT ); Wed, 27 Sep 2023 09:21:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231895AbjI0NVS (ORCPT ); Wed, 27 Sep 2023 09:21:18 -0400 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F75D199 for ; Wed, 27 Sep 2023 06:21:15 -0700 (PDT) Received: from [78.30.34.192] (port=42762 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qlUTR-00CXSJ-P4; Wed, 27 Sep 2023 15:21:13 +0200 Date: Wed, 27 Sep 2023 15:21:04 +0200 From: Pablo Neira Ayuso To: Thomas Haller Cc: NetFilter Subject: Re: [PATCH nft v2 1/1] mergesort: avoid cloning value in expr_msort_cmp() Message-ID: References: <20230927092104.2316284-1-thaller@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230927092104.2316284-1-thaller@redhat.com> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Sep 27, 2023 at 11:20:24AM +0200, Thomas Haller wrote: > If we have a plain EXPR_VALUE value, there is no need to copy > it via mpz_set(). Applied, thanks