From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Thomas Haller <thaller@redhat.com>
Cc: NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft 1/1] include: include <string.h> in <nft.h>
Date: Wed, 27 Sep 2023 21:59:05 +0200 [thread overview]
Message-ID: <ZRSJiZmMJOMnsgxG@calendula> (raw)
In-Reply-To: <20230927195133.3677265-1-thaller@redhat.com>
On Wed, Sep 27, 2023 at 09:51:15PM +0200, Thomas Haller wrote:
> <string.h> provides strcmp(), as such it's very basic and used
> everywhere.
>
> Include it via <nft.h>.
>
> The benefit of this will be to add a static-inline function
> nft_strcmp0() to <nft.h>, which calls strcmp() but handles that strings
> might be NULL. Such a basic utility will be useful, and <nft.h> is the
> right place. So we will need <string.h> there. Regardless of that, not
> including the same header basically everywhere, is already a benefit.
Applied, thanks
prev parent reply other threads:[~2023-09-27 19:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 19:51 [PATCH nft 1/1] include: include <string.h> in <nft.h> Thomas Haller
2023-09-27 19:59 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRSJiZmMJOMnsgxG@calendula \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).