From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A7DE82CCD for ; Wed, 27 Sep 2023 19:59:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229664AbjI0T7L (ORCPT ); Wed, 27 Sep 2023 15:59:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229595AbjI0T7K (ORCPT ); Wed, 27 Sep 2023 15:59:10 -0400 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5D4110E for ; Wed, 27 Sep 2023 12:59:09 -0700 (PDT) Received: from [78.30.34.192] (port=46706 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qlagc-00ETge-82; Wed, 27 Sep 2023 21:59:08 +0200 Date: Wed, 27 Sep 2023 21:59:05 +0200 From: Pablo Neira Ayuso To: Thomas Haller Cc: NetFilter Subject: Re: [PATCH nft 1/1] include: include in Message-ID: References: <20230927195133.3677265-1-thaller@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230927195133.3677265-1-thaller@redhat.com> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Sep 27, 2023 at 09:51:15PM +0200, Thomas Haller wrote: > provides strcmp(), as such it's very basic and used > everywhere. > > Include it via . > > The benefit of this will be to add a static-inline function > nft_strcmp0() to , which calls strcmp() but handles that strings > might be NULL. Such a basic utility will be useful, and is the > right place. So we will need there. Regardless of that, not > including the same header basically everywhere, is already a benefit. Applied, thanks