From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] evaluate: suggest != in negation error message
Date: Fri, 13 Oct 2023 13:08:09 +0200 [thread overview]
Message-ID: <ZSklGaIm2BDcVANw@calendula> (raw)
In-Reply-To: <20231013104154.7482-1-fw@strlen.de>
On Fri, Oct 13, 2023 at 12:41:49PM +0200, Florian Westphal wrote:
> when I run sudo nft insert rule filter FORWARD iifname "ens2f1" ip saddr not @ip_macs counter drop comment \" BLOCK ALL NON REGISTERED IP/MACS \"
> I get: Error: negation can only be used with singleton bitmask values
>
> And even I did not spot the problem immediately.
>
> I don't think "not" should have been added, its easily confused with
> "not equal"/"neq"/!= and hides that this is (allegedly) a bit operation.
>
> At least suggest to use != instead in the error message, I suspect it
> might lessen the pain.
LGTM.
prev parent reply other threads:[~2023-10-13 11:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 10:41 [PATCH nft] evaluate: suggest != in negation error message Florian Westphal
2023-10-13 11:08 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSklGaIm2BDcVANw@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).