netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH nft] tests/shell: add missing "elem_opts_compat_0.nodump" file
@ 2023-10-23 12:40 Thomas Haller
  2023-10-24  9:50 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Haller @ 2023-10-23 12:40 UTC (permalink / raw)
  To: NetFilter; +Cc: Thomas Haller

This is an inconsistency. The test should have either a .nft or a
.nodump file. "./tools/check-tree.sh" enforces that and will in the
future run by `make check`.

Fixes: 22fab8681a50 ('parser_bison: Fix for broken compatibility with older dumps')
Signed-off-by: Thomas Haller <thaller@redhat.com>
---
 tests/shell/testcases/sets/dumps/elem_opts_compat_0.nodump | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 tests/shell/testcases/sets/dumps/elem_opts_compat_0.nodump

diff --git a/tests/shell/testcases/sets/dumps/elem_opts_compat_0.nodump b/tests/shell/testcases/sets/dumps/elem_opts_compat_0.nodump
new file mode 100644
index 000000000000..e69de29bb2d1
-- 
2.41.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH nft] tests/shell: add missing "elem_opts_compat_0.nodump" file
  2023-10-23 12:40 [PATCH nft] tests/shell: add missing "elem_opts_compat_0.nodump" file Thomas Haller
@ 2023-10-24  9:50 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2023-10-24  9:50 UTC (permalink / raw)
  To: Thomas Haller; +Cc: NetFilter

On Mon, Oct 23, 2023 at 02:40:25PM +0200, Thomas Haller wrote:
> This is an inconsistency. The test should have either a .nft or a
> .nodump file. "./tools/check-tree.sh" enforces that and will in the
> future run by `make check`.

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-10-24  9:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-23 12:40 [PATCH nft] tests/shell: add missing "elem_opts_compat_0.nodump" file Thomas Haller
2023-10-24  9:50 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).