From: Phil Sutter <phil@nwl.cc>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 07/10] man: grammar fixes to some manpages
Date: Thu, 26 Oct 2023 14:53:13 +0200 [thread overview]
Message-ID: <ZTphOV/bYuotL2l0@orbyte.nwl.cc> (raw)
In-Reply-To: <20231026085506.94343-7-jengelh@inai.de>
On Thu, Oct 26, 2023 at 10:55:03AM +0200, Jan Engelhardt wrote:
> English generally uses open compounds rather than closed ones;
> fix the excess hyphens in words. Fix a missing dash for the
> portnr option as well.
>
> Signed-off-by: Jan Engelhardt <jengelh@inai.de>
> ---
> extensions/libxt_MASQUERADE.man | 2 +-
> extensions/libxt_helper.man | 10 +++++-----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/extensions/libxt_MASQUERADE.man b/extensions/libxt_MASQUERADE.man
> index e2009086..7cc2bb7a 100644
> --- a/extensions/libxt_MASQUERADE.man
> +++ b/extensions/libxt_MASQUERADE.man
> @@ -15,7 +15,7 @@ any established connections are lost anyway).
> \fB\-\-to\-ports\fP \fIport\fP[\fB\-\fP\fIport\fP]
> This specifies a range of source ports to use, overriding the default
> .B SNAT
> -source port-selection heuristics (see above). This is only valid
> +source port-selection heuristics (see above). This is only valid
Do you miss a dash in:
"default SNAT source port selection heuristics"? I lean towards putting
dashes everywhere, but my language spoils me. ;)
Thanks, Phil
next prev parent reply other threads:[~2023-10-26 12:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 8:54 [PATCH 01/10] man: display number ranges with an en dash Jan Engelhardt
2023-10-26 8:54 ` [PATCH 02/10] man: encode emdash the way groff/man requires it Jan Engelhardt
2023-10-26 8:54 ` [PATCH 03/10] man: encode math minuses " Jan Engelhardt
2023-10-26 8:55 ` [PATCH 04/10] man: encode hyphens " Jan Engelhardt
2023-10-26 8:55 ` [PATCH 05/10] man: encode minushyphen " Jan Engelhardt
2023-10-26 8:55 ` [PATCH 06/10] man: consistent casing of "IPv[46]" Jan Engelhardt
2023-10-26 8:55 ` [PATCH 07/10] man: grammar fixes to some manpages Jan Engelhardt
2023-10-26 12:53 ` Phil Sutter [this message]
2023-10-26 15:10 ` Jan Engelhardt
2023-10-27 11:10 ` Phil Sutter
2023-10-26 8:55 ` [PATCH 08/10] man: use native bullet point markup Jan Engelhardt
2023-10-26 8:55 ` [PATCH 09/10] man: use .TP for lists in xt_osf man page Jan Engelhardt
2023-10-26 12:26 ` Phil Sutter
2023-10-26 13:42 ` Jan Engelhardt
2023-10-26 8:55 ` [PATCH 10/10] man: reveal rateest's combination categories Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTphOV/bYuotL2l0@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).