From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAFE9C25B48 for ; Thu, 26 Oct 2023 12:53:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230330AbjJZMxR (ORCPT ); Thu, 26 Oct 2023 08:53:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230105AbjJZMxQ (ORCPT ); Thu, 26 Oct 2023 08:53:16 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7573AC for ; Thu, 26 Oct 2023 05:53:14 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1qvzrN-00069K-20; Thu, 26 Oct 2023 14:53:13 +0200 Date: Thu, 26 Oct 2023 14:53:13 +0200 From: Phil Sutter To: Jan Engelhardt Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH 07/10] man: grammar fixes to some manpages Message-ID: Mail-Followup-To: Phil Sutter , Jan Engelhardt , netfilter-devel@vger.kernel.org References: <20231026085506.94343-1-jengelh@inai.de> <20231026085506.94343-7-jengelh@inai.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231026085506.94343-7-jengelh@inai.de> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Oct 26, 2023 at 10:55:03AM +0200, Jan Engelhardt wrote: > English generally uses open compounds rather than closed ones; > fix the excess hyphens in words. Fix a missing dash for the > portnr option as well. > > Signed-off-by: Jan Engelhardt > --- > extensions/libxt_MASQUERADE.man | 2 +- > extensions/libxt_helper.man | 10 +++++----- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/extensions/libxt_MASQUERADE.man b/extensions/libxt_MASQUERADE.man > index e2009086..7cc2bb7a 100644 > --- a/extensions/libxt_MASQUERADE.man > +++ b/extensions/libxt_MASQUERADE.man > @@ -15,7 +15,7 @@ any established connections are lost anyway). > \fB\-\-to\-ports\fP \fIport\fP[\fB\-\fP\fIport\fP] > This specifies a range of source ports to use, overriding the default > .B SNAT > -source port-selection heuristics (see above). This is only valid > +source port-selection heuristics (see above). This is only valid Do you miss a dash in: "default SNAT source port selection heuristics"? I lean towards putting dashes everywhere, but my language spoils me. ;) Thanks, Phil