Re: [PATCH nft v3 1/1] tests/shell: sanitize "handle" in JSON output

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Wed, Nov 22, 2023 at 01:16:38PM +0100, Thomas Haller wrote:
[...]
> 
> Note that on `master` there are
> 
>   - 386 shell tests
>   - 14 tests with .nodump files
>   - 372 tests with .nft dump files (386-14)
>   - 339 tests with .json-nft files
>   - 33 tests that lack .json-nft files (372-339)
> 
> Meaning, that they are IMO useful already, and there is no immediate
> hurry to address the missing 33 files.

This is useful, almost complete coverage is better than no coverage :)

> PS: Reminder: you can identify missing .json-nft files by running
> `./tools/check-tree.sh`.

Thanks. Maybe update tests/shell/README to add a few lines, I like to
go there when I forget things and...

$ git grep check-tree README
$

shows nothing.

> You can generate missing files either via
> 
>   $ DUMPGEN=all ./tests/shell/run-tests.sh tests/shell/testcases/cache/0010_implicit_chain_0
> 
> or just
> 
>   $ touch tests/shell/testcases/cache/dumps/0010_implicit_chain_0.json-nft
>   $ ./tests/shell/run-tests.sh tests/shell/testcases/cache/0010_implicit_chain_0 -g

Yes, that is missing.