From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Thomas Haller <thaller@redhat.com>
Cc: NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft 1/1] tests: prettify JSON in test output and add helper
Date: Wed, 22 Nov 2023 18:36:44 +0100 [thread overview]
Message-ID: <ZV48LJYO0ObBy04G@calendula> (raw)
In-Reply-To: <267d0bff359a01b3222506e272bb1c2b63c154c8.camel@redhat.com>
On Wed, Nov 22, 2023 at 01:55:57PM +0100, Thomas Haller wrote:
[...]
> As always, you will find some result files in /tmp/nft-
> test.latest.$USER/, which I usually read with
>
> $ grep --color=always ^ -aR /tmp/nft-test.latest.*/ | less -R
>
> there will be a new file there, named "ruleset-diff.json.pretty".
>
> It contains the content of "./tests/shell/helpers/json-diff-pretty.sh"
> output.
>
>
> For example:
>
> $ cp tests/shell/testcases/bitwise/dumps/0040mark_binop_2.json-nft tests/shell/testcases/bitwise/dumps/0040mark_binop_3.json-nft
> $ ./tests/shell/run-tests.sh tests/shell/testcases/bitwise/0040mark_binop_3
>
>
> leaves a file
>
> /tmp/nft-test.latest.*/test-tests-shell-testcases-bitwise-0040mark_binop_3.1/ruleset-diff.json.pretty
Thanks for explaining, this is now applied.
And please, add copy and paste this info to the README file (unless I
am overlooking anything, it is not yet there).
next prev parent reply other threads:[~2023-11-22 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 11:19 [PATCH nft 1/1] tests: prettify JSON in test output and add helper Thomas Haller
2023-11-22 12:33 ` Pablo Neira Ayuso
2023-11-22 12:55 ` Thomas Haller
2023-11-22 17:36 ` Pablo Neira Ayuso [this message]
2023-11-22 18:23 ` Thomas Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZV48LJYO0ObBy04G@calendula \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).