From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Thomas Haller <thaller@redhat.com>,
NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft v3 2/6] tests/shell: check and generate JSON dump files
Date: Wed, 15 Nov 2023 13:30:23 +0100 [thread overview]
Message-ID: <ZVS530oqzSu/cgQS@calendula> (raw)
In-Reply-To: <20231115122105.GD23742@breakpoint.cc>
On Wed, Nov 15, 2023 at 01:21:05PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Wed, Nov 15, 2023 at 11:01:01AM +0100, Florian Westphal wrote:
> > [...]
> > > I'll double check this of course before pushing this out.
> >
> > OK, then all has been clarified and this can follow its route to git.
> >
> > I will follow up with my pending patches for tests/shell and older
> > kernels, with my last patch 5/4 it is done for kernel 5.4.
>
> I"ve pushed the series out. Note that I modified two dump files
> to account for "src: expand create commands", which did modify
> two tests in the mean time.
I see _lots_ of DUMP FAIL with kernel 5.4
I: [SKIPPED] 1/387 testcases/flowtable/0015destroy_0
W: [DUMP FAIL] 2/387 testcases/optimizations/merge_stmts_concat_vmap
I: [OK] 3/387 testcases/chains/0037policy_variable_1
I: [OK] 4/387 testcases/transactions/bad_expression
W: [DUMP FAIL] 5/387 testcases/sets/collapse_elem_0
I: [OK] 6/387 testcases/include/0009glob_nofile_1
W: [DUMP FAIL] 7/387 testcases/sets/0049set_define_0
W: [DUMP FAIL] 8/387 testcases/rule_management/0005replace_1
W: [DUMP FAIL] 9/387 testcases/flowtable/0003add_after_flush_0
W: [DUMP FAIL] 10/387 testcases/sets/0017add_after_flush_0
I: [OK] 11/387 testcases/chains/0011endless_jump_loop_1
I: [SKIPPED] 12/387 testcases/maps/0014destroy_0
I: [SKIPPED] 13/387 testcases/sets/0060set_multistmt_0
W: [DUMP FAIL] 14/387 testcases/cache/0004_cache_update_0
I: [OK] 15/387 testcases/transactions/0036set_1
W: [DUMP FAIL] 16/387 testcases/nft-f/0002rollback_rule_0
W: [DUMP FAIL] 17/387 testcases/chains/0022prio_dummy_1
W: [DUMP FAIL] 18/387 testcases/nft-f/0032pknock_0
I: [SKIPPED] 19/387 testcases/maps/0017_map_variable_0
I: [OK] 20/387 testcases/optionals/comments_objects_dup_0
I: [OK] 21/387 testcases/transactions/0014chain_1
W: [DUMP FAIL] 22/387 testcases/chains/0026prio_netdev_1
W: [DUMP FAIL] 23/387 testcases/optionals/handles_1
W: [DUMP FAIL] 24/387 testcases/include/0007glob_double_0
W: [DUMP FAIL] 25/387 testcases/transactions/0048helpers_0
W: [DUMP FAIL] 26/387 testcases/listing/0021ruleset_json_terse_0
W: [DUMP FAIL] 27/387 testcases/listing/0022terse_0
W: [DUMP FAIL] 28/387 testcases/chains/0017masquerade_jump_1
W: [DUMP FAIL] 29/387 testcases/sets/0016element_leak_0
...
next prev parent reply other threads:[~2023-11-15 12:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 15:29 [PATCH nft v3 0/6] add and check dump files for JSON in tests/shell Thomas Haller
2023-11-14 15:29 ` [PATCH nft v3 1/6] json: fix use after free in table_flags_json() Thomas Haller
2023-11-15 9:58 ` Pablo Neira Ayuso
2023-11-14 16:08 ` [PATCH nft v3 2/6] tests/shell: check and generate JSON dump files Thomas Haller
2023-11-14 16:08 ` [PATCH nft v3 4/6] tools: simplify error handling in "check-tree.sh" by adding msg_err()/msg_warn() Thomas Haller
2023-11-14 16:08 ` [PATCH nft v3 5/6] tools: check more strictly for bash shebang in "check-tree.sh" Thomas Haller
2023-11-14 16:08 ` [PATCH nft v3 6/6] tools: check for consistency of .json-nft dumps " Thomas Haller
2023-11-15 8:24 ` [PATCH nft v3 2/6] tests/shell: check and generate JSON dump files Florian Westphal
2023-11-15 9:54 ` Pablo Neira Ayuso
2023-11-15 10:01 ` Florian Westphal
2023-11-15 10:05 ` Pablo Neira Ayuso
2023-11-15 10:10 ` Florian Westphal
2023-11-15 10:26 ` Pablo Neira Ayuso
2023-11-15 10:31 ` Florian Westphal
2023-11-15 10:35 ` Pablo Neira Ayuso
2023-11-15 10:43 ` Pablo Neira Ayuso
2023-11-15 12:21 ` Florian Westphal
2023-11-15 12:30 ` Pablo Neira Ayuso [this message]
2023-11-15 12:36 ` Thomas Haller
2023-11-16 16:10 ` Pablo Neira Ayuso
2023-11-16 16:49 ` Thomas Haller
2023-11-16 16:55 ` Thomas Haller
2023-11-16 23:00 ` Florian Westphal
2023-11-16 23:02 ` Florian Westphal
2023-11-17 8:27 ` Pablo Neira Ayuso
2023-11-17 16:16 ` Thomas Haller
2023-11-17 16:36 ` Pablo Neira Ayuso
2023-11-17 16:56 ` Thomas Haller
2023-11-17 16:57 ` Phil Sutter
2023-11-17 17:06 ` Thomas Haller
2023-11-17 17:11 ` Phil Sutter
2023-11-17 17:23 ` Thomas Haller
2023-11-17 22:30 ` Phil Sutter
2023-11-15 10:11 ` Thomas Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVS530oqzSu/cgQS@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).