From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Thomas Haller <thaller@redhat.com>
Cc: netfilter-devel@vger.kernel.org, fw@strlen.de
Subject: Re: [PATCH nft 3/4] tests: shell: skip pipapo set backend in transactions/30s-stress
Date: Wed, 15 Nov 2023 11:34:46 +0100 [thread overview]
Message-ID: <ZVSexgxBFp3tZluj@calendula> (raw)
In-Reply-To: <8d3ccdafe00d9e477464e63619bde0e39c6da093.camel@redhat.com>
On Wed, Nov 15, 2023 at 11:25:44AM +0100, Thomas Haller wrote:
> On Wed, 2023-11-15 at 10:42 +0100, Pablo Neira Ayuso wrote:
> >
> >
> > +if [ "$NFT_TEST_HAVE_pipapo" != y ] ;then
> > + echo "Skipping pipapo set backend, kernel does not support
> > it"
> > +fi
>
> It's good and useful to run a reduced subset of the test, if some
> kernel feature is missing.
>
> But in that case, the end of the test should have something like
>
> if [ "$NFT_TEST_HAVE_pipapo" = n ] ; then
> echo "Ran a partial test only, due to NFT_TEST_HAVE_pipapo=n"
> exit 77
> fi
>
> so that it shows up as skipped. In other words, "partially skipped"
> should also show up as skipped.
I don't want this.
This test is very useful in older kernels to catch bugs, I don't want
to see a SKIPPED here.
I prefer the tests autoadapts itself to what the kernel provides.
next prev parent reply other threads:[~2023-11-15 10:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 9:42 [PATCH nft 0/4] more tests/shell updates to run on 5.4 kernels Pablo Neira Ayuso
2023-11-15 9:42 ` [PATCH nft 1/4] tests: shell: skip if kernel does not support flowtable counter Pablo Neira Ayuso
2023-11-15 9:42 ` [PATCH nft 2/4] tests: shell: skip if kernel does not support flowtable with no devices Pablo Neira Ayuso
2023-11-15 9:42 ` [PATCH nft 3/4] tests: shell: skip pipapo set backend in transactions/30s-stress Pablo Neira Ayuso
2023-11-15 10:25 ` Thomas Haller
2023-11-15 10:34 ` Pablo Neira Ayuso [this message]
2023-11-15 9:42 ` [PATCH nft 4/4] tests: shell: restore pipapo and chain binding coverage in standalone 30s-stress Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVSexgxBFp3tZluj@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).