netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Thomas Haller <thaller@redhat.com>
Cc: Phil Sutter <phil@nwl.cc>, NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft 1/1] tests/shell: sanitize "handle" in JSON output
Date: Tue, 21 Nov 2023 13:45:20 +0100	[thread overview]
Message-ID: <ZVymYDwWLQBQUAAg@calendula> (raw)
In-Reply-To: <f4b86e5318556be07a8c86c3fdd551ad5e22a831.camel@redhat.com>

Hi Thomas,

On Tue, Nov 21, 2023 at 01:10:11PM +0100, Thomas Haller wrote:
> On Sat, 2023-11-18 at 03:36 +0100, Phil Sutter wrote:
> > On Fri, Nov 17, 2023 at 06:18:45PM +0100, Thomas Haller wrote:
[...]
> > > Note that only a few .json-nft files are adjusted, because
> > > otherwise the
> > > patch is too large. Before applying, you need to adjust them all,
> > > by
> > > running `./tests/shell/run-tests.sh -g`.
> > 
> > Just put the bulk change into a second patch?
> 
> it would require 3 patches to stay below the limit.
> 
> Also, it blows up the inbox by everybody on the list by 850K (57k
> gzipped). The rest of the patch is generated. Just generate it.

Excuse for jumping through this, just a submission style notice:

Please, Cc maintainers with big patches that don't fit in into the
mailing list in the future.

> Alternatively,
> 
>   git fetch https://gitlab.freedesktop.org/thaller/nftables df984038a33c6da5b159e6f6458351c4fa673bf1
>   git merge FETCH_HEAD

I'd suggest you place this also in the cover letter, so at least there
is a record on the mailing list archive that some patches could not
get through but there was an alternative way to take them for others.
As for maintainers, they can collect the large patch as attachment
from the email.

Thanks.

  parent reply	other threads:[~2023-11-21 12:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17 17:18 [PATCH nft 1/1] tests/shell: sanitize "handle" in JSON output Thomas Haller
2023-11-18  2:36 ` Phil Sutter
2023-11-21 12:10   ` Thomas Haller
2023-11-21 12:39     ` Phil Sutter
2023-11-21 12:58       ` Thomas Haller
2023-11-21 13:40         ` Phil Sutter
2023-11-21 14:35           ` Thomas Haller
2023-11-21 15:19             ` Phil Sutter
2023-11-21 12:45     ` Pablo Neira Ayuso [this message]
     [not found]       ` <20231121132331.3401846-1-thaller@redhat.com>
2023-11-22 10:36         ` [PATCH nft v3 " Pablo Neira Ayuso
2023-11-22 10:44           ` Thomas Haller
2023-11-22 11:22             ` Pablo Neira Ayuso
2023-11-22 12:16               ` Thomas Haller
2023-11-22 12:32                 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZVymYDwWLQBQUAAg@calendula \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    --cc=thaller@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).