From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] initial support for the afl++ (american fuzzy lop++) fuzzer
Date: Wed, 6 Dec 2023 14:30:50 +0100 [thread overview]
Message-ID: <ZXB3ikEXjBz9r1pS@orbyte.nwl.cc> (raw)
In-Reply-To: <20231206131340.GL8352@breakpoint.cc>
On Wed, Dec 06, 2023 at 02:13:40PM +0100, Florian Westphal wrote:
> Phil Sutter <phil@nwl.cc> wrote:
> > Hmm. Probably I miss the point regarding struct nft_afl_input. IMO, if
> > save_candidate() writes data into the file despite called savebuf()
> > setting use_filename = false, nft_afl_run_cmd() will try to read from
> > ->buffer when it should read from ->fname.
>
> In that case buffer should have same content as the on-disk file,
> so there is no need to open/read/close.
Ah, heh. I managed to ignore the mandatory snprintf() call in savebuf().
So it's indeed just "file backed buffer storage". Thanks for explaining!
Cheers, Phil
prev parent reply other threads:[~2023-12-06 13:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 15:43 [PATCH nft] initial support for the afl++ (american fuzzy lop++) fuzzer Florian Westphal
2023-12-01 18:57 ` Phil Sutter
2023-12-06 2:11 ` Phil Sutter
2023-12-06 7:43 ` Florian Westphal
2023-12-06 13:03 ` Phil Sutter
2023-12-06 13:13 ` Florian Westphal
2023-12-06 13:30 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXB3ikEXjBz9r1pS@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).