From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 4/4] Revert "datatype: do not assert when value exceeds expected width"
Date: Thu, 11 Jan 2024 10:30:25 +0100 [thread overview]
Message-ID: <ZZ+1MR6osSfdRkK4@calendula> (raw)
In-Reply-To: <20240110225738.GB28014@breakpoint.cc>
On Wed, Jan 10, 2024 at 11:57:38PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > # nft -f ruleset.nft
> > ruleset.nft:3:28-35: Error: expression is not a concatenation
> > ip protocol . th dport { tcp / 22, }
> > ^^^^^^^^
> >
> > Therefore, a852022d719e ("datatype: do not assert when value exceeds
> > expected width") not needed anymore after two previous fixes.
>
> We can't rely on the expression soup coming from nftables.
I can keep this patch then, no problem.
Or you mean this series is botched? Please elaborate :)
prev parent reply other threads:[~2024-01-11 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 19:42 [PATCH nft 0/4] assorted fixes Pablo Neira Ayuso
2024-01-10 19:42 ` [PATCH nft 1/4] evaluate: skip anonymous set optimization for concatenations Pablo Neira Ayuso
2024-01-10 19:42 ` [PATCH nft 2/4] evaluate: do not fetch next expression on runaway number of concatenation components Pablo Neira Ayuso
2024-01-10 19:42 ` [PATCH nft 3/4] evaluate: bail out if anonymous concat set defines a non concat expression Pablo Neira Ayuso
2024-01-10 19:42 ` [PATCH nft 4/4] Revert "datatype: do not assert when value exceeds expected width" Pablo Neira Ayuso
2024-01-10 22:57 ` Florian Westphal
2024-01-11 9:30 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZ+1MR6osSfdRkK4@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox