From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>,
Eric Garver <e@erig.me>
Subject: Re: [nf-next PATCH v2 0/3] netfilter: nf_tables: Introduce NFT_TABLE_F_PERSIST
Date: Tue, 9 Jan 2024 21:53:04 +0100 [thread overview]
Message-ID: <ZZ2yMKXhC8e6MSKA@calendula> (raw)
In-Reply-To: <20231221133159.31198-1-phil@nwl.cc>
Hi Phil,
Thanks for this v2.
On Thu, Dec 21, 2023 at 02:31:56PM +0100, Phil Sutter wrote:
> Changes since v1:
> - Split changes into separate patches to clarify which chunks belong
> together
> - Do not support persist flag toggling as suggested
> - Make transaction aware of ongoing table adoption, reverse it during
> rollback.
This series LGTM, let's put this in nf-next once the netdev merge
window opens up again.
Apologies for taking a while to review.
prev parent reply other threads:[~2024-01-09 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 13:31 [nf-next PATCH v2 0/3] netfilter: nf_tables: Introduce NFT_TABLE_F_PERSIST Phil Sutter
2023-12-21 13:31 ` [nf-next PATCH v2 1/3] netfilter: uapi: Document NFT_TABLE_F_OWNER flag Phil Sutter
2023-12-21 13:31 ` [nf-next PATCH v2 2/3] netfilter: nf_tables: Introduce NFT_TABLE_F_PERSIST Phil Sutter
2023-12-21 13:31 ` [nf-next PATCH v2 3/3] netfilter: nf_tables: Implement table adoption support Phil Sutter
2024-01-09 20:53 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZ2yMKXhC8e6MSKA@calendula \
--to=pablo@netfilter.org \
--cc=e@erig.me \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).