From: Phil Sutter <phil@nwl.cc>
To: Jacek Tomasiak <jacek.tomasiak@gmail.com>
Cc: netfilter-devel@vger.kernel.org, Jacek Tomasiak <jtomasiak@arista.com>
Subject: Re: [iptables PATCH] iptables: Add missing error codes
Date: Tue, 23 Jan 2024 13:33:48 +0100 [thread overview]
Message-ID: <Za-yLDmJofXFCuPu@orbyte.nwl.cc> (raw)
In-Reply-To: <20240123101428.19535-1-jacek.tomasiak@gmail.com>
Hi,
On Tue, Jan 23, 2024 at 11:14:27AM +0100, Jacek Tomasiak wrote:
> Without these, commands like `iptables -n -L CHAIN` sometimes print
> "Incompatible with this kernel" instead of "No chain/target/match
> by that name".
Thanks for the fix! I see errno value is tainted by unrelated code-paths
if not explicitly set, but I failed to find a working reproducer. Do you
have one at hand? Would be good to add a test and maybe add a Fixes: tag
unless this is a day-1 bug.
Cheers, Phil
next prev parent reply other threads:[~2024-01-23 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 10:14 [iptables PATCH] iptables: Add missing error codes Jacek Tomasiak
2024-01-23 12:33 ` Phil Sutter [this message]
2024-01-23 16:14 ` Jacek Tomasiak
2024-01-24 14:37 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za-yLDmJofXFCuPu@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=jacek.tomasiak@gmail.com \
--cc=jtomasiak@arista.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).