From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [213.95.27.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC6BE637; Wed, 17 Jan 2024 12:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.27.120 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705495467; cv=none; b=IV1tg02pN3ipAL6wHmPthXvUDYxKd3wuIUQb92VRn8ikdhBt4HhUaXTTQfIDVk92N7oTrfi3MsY2wdYdecElqbRbseSA8nkYm89HupfaUw8LGQ/Ou12oaAFY/nX9KdBLiuGGqmaz3KW9Y4C59uvzZsAhPU5z5tIouTuqSIvygM4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705495467; c=relaxed/simple; bh=KoXalv3CDMgZHjdkgvPU6xGKSYFCIOANzZIRheAObrg=; h=Received:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To: X-Spam-Score; b=HX73OBww9I13jMvEnUf/t1T6wKe8wVAzQzGXQCJbm570rB9yHNA6Tinxz6/owf8/iT+Q0kCT9F1BDp76qoVmawHdd4FU/rJZRwxZDw7Y8eRNWJTyArwmEQkFvXtonZV3k4wUmhtesOxKv3JQwSQXWtAnwTZryMhcMtYpEoidxE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=gnumonks.org; arc=none smtp.client-ip=213.95.27.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gnumonks.org Received: from [78.30.41.52] (port=34296 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rQ5HH-00DsEM-LJ; Wed, 17 Jan 2024 13:44:21 +0100 Date: Wed, 17 Jan 2024 13:44:18 +0100 From: Pablo Neira Ayuso To: Fedor Pchelkin Cc: Simon Horman , Julian Anastasov , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Dwip Banerjee , netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org Subject: Re: [PATCH net] net: ipvs: avoid stat macros calls from preemptible context Message-ID: References: <20240115143923.31243-1-pchelkin@ispras.ru> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240115143923.31243-1-pchelkin@ispras.ru> X-Spam-Score: -1.9 (-) On Mon, Jan 15, 2024 at 05:39:22PM +0300, Fedor Pchelkin wrote: > Inside decrement_ttl() upon discovering that the packet ttl has exceeded, > __IP_INC_STATS and __IP6_INC_STATS macros can be called from preemptible > context having the following backtrace: > > check_preemption_disabled: 48 callbacks suppressed > BUG: using __this_cpu_add() in preemptible [00000000] code: curl/1177 > caller is decrement_ttl+0x217/0x830 Applied to nf.git, thanks