netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Felix Huettner <felix.huettner@mail.schwarz>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH libnetfilter_conntrack 1/2] dump: support filtering by zone
Date: Wed, 24 Jan 2024 21:23:09 +0100	[thread overview]
Message-ID: <ZbFxrXUrCklFBOSP@calendula> (raw)
In-Reply-To: <f5abe59a5d9577db8a5e07317aab90cede94d90a.1701675975.git.felix.huettner@mail.schwarz>

On Tue, Dec 05, 2023 at 09:35:03AM +0000, Felix Huettner wrote:
> diff --git a/include/libnetfilter_conntrack/libnetfilter_conntrack.h b/include/libnetfilter_conntrack/libnetfilter_conntrack.h
> index 76b5c27..2e9458a 100644
> --- a/include/libnetfilter_conntrack/libnetfilter_conntrack.h
> +++ b/include/libnetfilter_conntrack/libnetfilter_conntrack.h
> @@ -547,6 +547,7 @@ enum nfct_filter_dump_attr {
>  	NFCT_FILTER_DUMP_MARK = 0,	/* struct nfct_filter_dump_mark */
>  	NFCT_FILTER_DUMP_L3NUM,		/* uint8_t */
>  	NFCT_FILTER_DUMP_STATUS,	/* struct nfct_filter_dump_mark */
> +	NFCT_FILTER_DUMP_ZONE,		/* uint16_t */
>  	NFCT_FILTER_DUMP_TUPLE,
>  	NFCT_FILTER_DUMP_MAX
>  };

Applied with nit. I had to move NFCT_FILTER_DUMP_ZONE after
NFCT_FILTER_DUMP_TUPLE in enum nfct_filter_dump_attr, otherwise it
breaks ABI.

  reply	other threads:[~2024-01-24 20:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05  9:34 [PATCH libnetfilter_conntrack 0/2] dump/flush support filtering by zone Felix Huettner
2023-12-05  9:35 ` [PATCH libnetfilter_conntrack 1/2] dump: " Felix Huettner
2024-01-24 20:23   ` Pablo Neira Ayuso [this message]
2023-12-05  9:35 ` [PATCH libnetfilter_conntrack 2/2] flush: support filtering Felix Huettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbFxrXUrCklFBOSP@calendula \
    --to=pablo@netfilter.org \
    --cc=felix.huettner@mail.schwarz \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).