* [nft PATCH v3] evaluate: fix check for unknown in cmd_op_to_name
@ 2024-02-07 15:10 谢致邦 (XIE Zhibang)
2024-02-07 17:06 ` Phil Sutter
0 siblings, 1 reply; 2+ messages in thread
From: 谢致邦 (XIE Zhibang) @ 2024-02-07 15:10 UTC (permalink / raw)
To: netfilter-devel; +Cc: phil, 谢致邦 (XIE Zhibang)
Example:
nft --debug=all destroy table ip missingtable
Before:
Evaluate unknown
After:
Evaluate destroy
Fixes: e1dfd5cc4c46 ("src: add support to command "destroy"")
Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
---
V2 -> V3: Use array_size as suggested by Phil Sutter
V1 -> V2: Update subject and message
src/evaluate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/evaluate.c b/src/evaluate.c
index 68cfd7765381..57da4044e8c0 100644
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -6048,7 +6048,7 @@ static const char * const cmd_op_name[] = {
static const char *cmd_op_to_name(enum cmd_ops op)
{
- if (op > CMD_DESCRIBE)
+ if (op >= array_size(cmd_op_name))
return "unknown";
return cmd_op_name[op];
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [nft PATCH v3] evaluate: fix check for unknown in cmd_op_to_name
2024-02-07 15:10 [nft PATCH v3] evaluate: fix check for unknown in cmd_op_to_name 谢致邦 (XIE Zhibang)
@ 2024-02-07 17:06 ` Phil Sutter
0 siblings, 0 replies; 2+ messages in thread
From: Phil Sutter @ 2024-02-07 17:06 UTC (permalink / raw)
To: 谢致邦 (XIE Zhibang); +Cc: netfilter-devel
On Wed, Feb 07, 2024 at 03:10:20PM +0000, 谢致邦 (XIE Zhibang) wrote:
> Example:
> nft --debug=all destroy table ip missingtable
>
> Before:
> Evaluate unknown
>
> After:
> Evaluate destroy
>
> Fixes: e1dfd5cc4c46 ("src: add support to command "destroy"")
> Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
Patch applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-07 17:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-07 15:10 [nft PATCH v3] evaluate: fix check for unknown in cmd_op_to_name 谢致邦 (XIE Zhibang)
2024-02-07 17:06 ` Phil Sutter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).