From: Phil Sutter <phil@nwl.cc>
To: Thomas Haller <thaller@redhat.com>
Cc: NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 1/1] tests: use common shebang in "packetpath/flowtables" test
Date: Fri, 9 Feb 2024 14:34:48 +0100 [thread overview]
Message-ID: <ZcYp-McSsMiw6Wry@orbyte.nwl.cc> (raw)
In-Reply-To: <20240209121603.2294742-1-thaller@redhat.com>
On Fri, Feb 09, 2024 at 01:13:04PM +0100, Thomas Haller wrote:
> "./tools/check-tree.sh" checks for a certain shebang. Either `/bin/bash` or
> `/bin/bash -e`. No other are currently allowed, because it makes sense to be
> strict/consistent and there is no need such flexibility.
Why be picky about extra flags to /bin/bash? If you assert the first
"word" after #! is as expected, the remaining bits are known to be
bash-compatible at least, no?
> Move the "-x" to a later command.
>
> Note that "set -x" may not be a good choice anyway. If you want to debug
> a test and see the shell commands, you could just run
>
> $ ./tests/shell/run-tests.sh tests/shell/testcases/packetpath/flowtables -x
Please document such things before denying other ways to achieve the
same. ;)
Seriously, if this is the way to run the tests with tracing enabled, it
should be explained in tests/shell/README.
Cheers, Phil
prev parent reply other threads:[~2024-02-09 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 12:13 [PATCH 1/1] tests: use common shebang in "packetpath/flowtables" test Thomas Haller
2024-02-09 13:34 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcYp-McSsMiw6Wry@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).