From: Phil Sutter <phil@nwl.cc>
To: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] nft: Fix for broken recover_rule_compat()
Date: Wed, 28 Feb 2024 13:21:29 +0100 [thread overview]
Message-ID: <Zd8lSShzA4NJrp-C@orbyte.nwl.cc> (raw)
In-Reply-To: <20240227184057.6017-1-phil@nwl.cc>
On Tue, Feb 27, 2024 at 07:40:57PM +0100, Phil Sutter wrote:
> When IPv4 rule generator was changed to emit payload instead of
> meta expressions for l4proto matches, the code reinserting
> NFTNL_RULE_COMPAT_* attributes into rules being reused for counter
> zeroing was broken by accident.
>
> Make rule compat recovery aware of the alternative match, basically
> reinstating the effect of commit 7a373f6683afb ("nft: Fix -Z for rules
> with NFTA_RULE_COMPAT") but add a test case this time to make sure
> things stay intact.
>
> Fixes: 69278f9602b43 ("nft: use payload matching for layer 4 protocol")
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Patch applied.
prev parent reply other threads:[~2024-02-28 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 18:40 [iptables PATCH] nft: Fix for broken recover_rule_compat() Phil Sutter
2024-02-28 12:21 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd8lSShzA4NJrp-C@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).