netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Donald Yandt <donald.yandt@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH conntrack-tools 2/3] conntrackd: use size_t for element indices
Date: Mon, 4 Mar 2024 13:35:11 +0100	[thread overview]
Message-ID: <ZeW__zJ0C-JJdSBw@calendula> (raw)
In-Reply-To: <CADm=fg=TbKc8D-nzY7kA=NT7Fi_ZJ7ZLA3uJB-7+bK2-s5W3FQ@mail.gmail.com>

On Sat, Mar 02, 2024 at 11:20:38AM -0500, Donald Yandt wrote:
> On Sat, Mar 2, 2024 at 4:53 AM Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> >
> > Hi,
> >
> > Could you describe why these are needed?
> >
> > Thanks!
> >
> 
> Hi Pablo,
> 
> I mentioned it briefly in the cover letter and explained why it should
> be used in the commit message for version 2.
> If you require any additional detail, please let me know.

Cover letter gets lost when applying patches.

Split descriptions into each individual commit, it really helps us.

Thanks a lot

  reply	other threads:[~2024-03-04 12:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01 17:07 [PATCH conntrack-tools 0/3] fix potential memory loss and exit codes Donald Yandt
2024-03-01 17:07 ` [PATCH conntrack-tools 1/3] conntrackd: prevent memory loss if reallocation fails Donald Yandt
2024-03-02  9:54   ` Pablo Neira Ayuso
2024-03-02 16:26     ` Donald Yandt
2024-03-01 17:07 ` [PATCH conntrack-tools 2/3] conntrackd: use size_t for element indices Donald Yandt
2024-03-02  9:53   ` Pablo Neira Ayuso
2024-03-02 16:20     ` Donald Yandt
2024-03-04 12:35       ` Pablo Neira Ayuso [this message]
2024-03-01 17:07 ` [PATCH conntrack-tools 3/3] conntrackd: exit with failure status Donald Yandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZeW__zJ0C-JJdSBw@calendula \
    --to=pablo@netfilter.org \
    --cc=donald.yandt@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).