[RFC nftables PATCH]: fix a2x: ERROR: missing --destination-dir: ./doc

[RFC nftables PATCH]: fix a2x: ERROR: missing --destination-dir: ./doc

[Neels Hofmeyr]

[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]

Since recently, I'm getting this build error from nftables, quite definitely
because I am building in a separate directory, and not in the source tree
itself.

	  GEN      doc/nft.8
	  GEN      doc/libnftables-json.5
	  GEN      doc/libnftables.3
	a2x: ERROR: missing --destination-dir: ./doc

	make[2]: *** [Makefile:1922: doc/nft.8] Error 1

May I suggest attached patch.

An alternative might be an entry in AC_CONFIG_FILES? In the source trees at
osmocom we usually have a Makefile generated in each output dir, which solves
any missing directory problems.

I haven't investigated the cause, maybe it is some change on my system that
suddenly exposes this; there was some serious package upgrading going on half
an hour ago.

Thanks!

~N

-- 
- Neels Hofmeyr <nhofmeyr@sysmocom.de>          http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschäftsführer / Managing Directors: Harald Welte

[-- Attachment #2: 0001-mkdir-builddir-doc.patch --]
[-- Type: text/x-diff, Size: 696 bytes --]

From b15204aa58c09d2a9368aa6c074be086fc481ece Mon Sep 17 00:00:00 2001
From: Neels Hofmeyr <nhofmeyr@sysmocom.de>
Date: Fri, 8 Mar 2024 00:42:50 +0100
Subject: [PATCH] mkdir $(builddir}/doc

When building separately from the source tree (as in ../src/configure),
the 'doc' dir is not present from just the source tree. Create the dir
before calling a2x.
---
 Makefile.am | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile.am b/Makefile.am
index 688a9849..fef1d8d1 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -342,6 +342,7 @@ EXTRA_DIST += \
 CLEANFILES += doc/*~
 
 doc/nft.8: $(ASCIIDOCS)
+	mkdir -p ${builddir}/doc
 	$(AM_V_GEN)$(A2X) $(A2X_OPTS_MANPAGE) $<
 
 .adoc.3:
-- 
2.43.0

Re: [RFC nftables PATCH]: fix a2x: ERROR: missing --destination-dir: ./doc

[Phil Sutter]

On Fri, Mar 08, 2024 at 12:54:27AM +0100, Neels Hofmeyr wrote:
> Since recently, I'm getting this build error from nftables, quite definitely
> because I am building in a separate directory, and not in the source tree
> itself.
> 
> 	  GEN      doc/nft.8
> 	  GEN      doc/libnftables-json.5
> 	  GEN      doc/libnftables.3
> 	a2x: ERROR: missing --destination-dir: ./doc
> 
> 	make[2]: *** [Makefile:1922: doc/nft.8] Error 1
> 
> May I suggest attached patch.

Patch applied after adding "Makefile:" prefix and your SoB.

Thanks, Phil