From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-44.mimecast.com (us-smtp-delivery-44.mimecast.com [207.211.30.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A78AD18C05 for ; Mon, 29 Apr 2024 08:54:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=207.211.30.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714380853; cv=none; b=FUn+wx0wtwy5jA5xaT8h8Ti+kmrXWy3UxCmLC2X5opHaeNUCm6Ews8W2RDzkUDA5wvmrP7xoRkqFtix99LqKAZmPP4DsQuiNoyTydXRY+XBzh3BGwrHLj3uKbXckjEITPe1FpP/JDGOIFeP58xdxpqVoKDiAs4c1bbpqmfJMkC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714380853; c=relaxed/simple; bh=15p9jTZ2hEXQyesHe8ZLvFtpZ8Mfmfy/0ZKJ3CCg11M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=eg3+aIsRJVxbQGpTLgoCBMUUNUdkqbgwUnuJfikrfc/V/0v6I926fLzibsZt4jTJSknrDX8ozCSVhFOVLVl+dGVjbkBTP8gZvmK5vOoGRqhmnFYKfA4XsE129MblEM7xOSrFEvAY/mZi2srVqvos5vudRH18UifOj6ULdqK8LUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=none smtp.mailfrom=queasysnail.net; arc=none smtp.client-ip=207.211.30.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=queasysnail.net Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-rVXMo5ZLPx-cd8GI79VPfQ-1; Mon, 29 Apr 2024 04:53:59 -0400 X-MC-Unique: rVXMo5ZLPx-cd8GI79VPfQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9E4713806704; Mon, 29 Apr 2024 08:53:58 +0000 (UTC) Received: from hog (unknown [10.39.193.137]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B198740BB4E; Mon, 29 Apr 2024 08:53:48 +0000 (UTC) Date: Mon, 29 Apr 2024 10:53:47 +0200 From: Sabrina Dubroca To: j.granados@samsung.com Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Aring , Stefan Schmidt , Miquel Raynal , David Ahern , Steffen Klassert , Herbert Xu , Matthieu Baerts , Mat Martineau , Geliang Tang , Remi Denis-Courmont , Allison Henderson , David Howells , Marc Dionne , Marcelo Ricardo Leitner , Xin Long , Wenjia Zhang , Jan Karcher , "D. Wythe" , Tony Lu , Wen Gu , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Jon Maloy , Ying Xue , Martin Schiller , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Roopa Prabhu , Nikolay Aleksandrov , Simon Horman , Julian Anastasov , Joerg Reuter , Luis Chamberlain , Kees Cook , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dccp@vger.kernel.org, linux-wpan@vger.kernel.org, mptcp@lists.linux.dev, linux-hams@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-afs@lists.infradead.org, linux-sctp@vger.kernel.org, linux-s390@vger.kernel.org, linux-nfs@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-x25@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux.dev, lvs-devel@vger.kernel.org Subject: Re: [PATCH v5 1/8] net: Remove the now superfluous sentinel elements from ctl_table array Message-ID: References: <20240426-jag-sysctl_remset_net-v5-0-e3b12f6111a6@samsung.com> <20240426-jag-sysctl_remset_net-v5-1-e3b12f6111a6@samsung.com> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240426-jag-sysctl_remset_net-v5-1-e3b12f6111a6@samsung.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: queasysnail.net Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable 2024-04-26, 12:46:53 +0200, Joel Granados via B4 Relay wrote: > diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c > index 6973dda3abda..a84690b13bb9 100644 > --- a/net/core/sysctl_net_core.c > +++ b/net/core/sysctl_net_core.c [...] > @@ -723,12 +722,11 @@ static __net_init int sysctl_core_net_init(struct n= et *net) > =09=09if (tbl =3D=3D NULL) > =09=09=09goto err_dup; > =20 > -=09=09for (tmp =3D tbl; tmp->procname; tmp++) > -=09=09=09tmp->data +=3D (char *)net - (char *)&init_net; Some coding style nits in case you re-post: > +=09=09for (int i =3D 0; i < table_size; ++i) move the declaration of int i out of the for (), it's almost never written this way (at least in networking) > +=09=09=09(tbl + i)->data +=3D (char *)net - (char *)&init_net; tbl[i].data =3D ... is more in line with other similar functions in the rest of net/ [...] > diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c > index 6dab883a08dd..ecc849678e7b 100644 > --- a/net/mpls/af_mpls.c > +++ b/net/mpls/af_mpls.c [...] > @@ -2674,6 +2673,7 @@ static const struct ctl_table mpls_table[] =3D { > =20 > static int mpls_net_init(struct net *net) > { > +=09size_t table_size =3D ARRAY_SIZE(mpls_table); This table still has a {} as its final element. It should be gone too? --=20 Sabrina