Linux Netfilter development
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alexander Maltsev <keltar.gw@gmail.com>
Cc: netfilter-devel@vger.kernel.org, Jozsef Kadlecsik <kadlec@netfilter.org>
Subject: Re: [PATCH] netfilter: ipset: Add list flush to cancel_gc
Date: Mon, 20 May 2024 11:53:53 +0200	[thread overview]
Message-ID: <ZksdsVn2atP2Wrzt@calendula> (raw)
In-Reply-To: <20240417135141.18288-1-keltar.gw@gmail.com>

On Wed, Apr 17, 2024 at 06:51:41PM +0500, Alexander Maltsev wrote:
> Flushing list in cancel_gc drops references to other lists right away,
> without waiting for RCU to destroy list. Fixes race when referenced
> ipsets can't be destroyed while referring list is scheduled for destroy.

For the record, I have applied this patch to nf.git with this tag:

Fixes: 97f7cf1cd80e ("netfilter: ipset: fix performance regression in swap operation")

I overlook this patch, apologies for the delay.

      parent reply	other threads:[~2024-05-20  9:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-17 13:51 [PATCH] netfilter: ipset: Add list flush to cancel_gc Alexander Maltsev
2024-04-22  8:32 ` Jozsef Kadlecsik
2024-05-20  9:53 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZksdsVn2atP2Wrzt@calendula \
    --to=pablo@netfilter.org \
    --cc=kadlec@netfilter.org \
    --cc=keltar.gw@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox