From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Antonio Ojea <aojea@google.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] netfilter: nfqueue: incorrect sctp checksum
Date: Tue, 11 Jun 2024 10:46:43 +0200 [thread overview]
Message-ID: <ZmgO89CFtn19EDAi@calendula> (raw)
In-Reply-To: <20240602153033.GA8496@breakpoint.cc>
On Sun, Jun 02, 2024 at 05:30:33PM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > Yes, this is implicit case: skb is gso. This is adding an exception
> > for sctp-gso.
>
> Is that because sctp gso carries a new / distinct sctp header
> per frag?
>
> If so, we can't extend skb_zerocopy, as it would create
> a bogus packet.
>
> The only "speedup" we could do in that case is that we
> do not need to fix the header csum if userspace enabled
> GSO support as long as we indicate csum correctness via
> the NFQA_SKB_CSUMNOTREADY flag.
>
> But that should probably be done at a later time.
I have posted a new series:
https://patchwork.ozlabs.org/project/netfilter-devel/list/?series=410326
SCTP packets enter skb_gso_segment() before being sent to userspace
not to break semantics.
I have revisited and extended the tests to exercise GSO path from the
output path.
prev parent reply other threads:[~2024-06-11 8:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 22:00 [PATCH v3 0/2] netfilter: nfqueue: incorrect sctp checksum Antonio Ojea
2024-05-13 22:00 ` [PATCH v3 1/2] netfilter: nft_queue: compute SCTP checksum Antonio Ojea
2024-05-13 22:18 ` Florian Westphal
2024-05-13 22:00 ` [PATCH v3 2/2] selftests: net: netfilter: nft_queue.sh: sctp checksum Antonio Ojea
2024-05-13 22:18 ` Florian Westphal
2024-05-20 11:27 ` [PATCH v3 0/2] netfilter: nfqueue: incorrect " Pablo Neira Ayuso
2024-05-20 15:44 ` Pablo Neira Ayuso
2024-05-20 18:33 ` Pablo Neira Ayuso
2024-05-20 18:47 ` Pablo Neira Ayuso
2024-05-20 18:59 ` Antonio Ojea
2024-05-21 10:48 ` Pablo Neira Ayuso
2024-05-21 10:51 ` Florian Westphal
2024-05-21 12:07 ` Pablo Neira Ayuso
2024-05-21 12:48 ` Florian Westphal
2024-05-21 12:58 ` Pablo Neira Ayuso
2024-06-02 15:30 ` Florian Westphal
2024-06-11 8:46 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmgO89CFtn19EDAi@calendula \
--to=pablo@netfilter.org \
--cc=aojea@google.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).